[ 
https://issues.apache.org/jira/browse/HADOOP-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730287#action_12730287
 ] 

Hadoop QA commented on HADOOP-6143:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12413189/HADOOP-6143.patch
  against trunk revision 793162.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/569/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/569/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/569/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/569/console

This message is automatically generated.

> FS shell commands returns incorrect exit code  when error occurs
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6143
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6143
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Ravi Phulari
>            Assignee: Ravi Phulari
>         Attachments: HADOOP-6143.patch
>
>
> HDFS documentation ( 
> http://hadoop.apache.org/core/docs/current/hdfs_shell.html#du )  mentions 
> that 
> {noformat}
> Exit Code:
> Returns 0 on success and -1 on error. 
> {noformat} 
> Current Fs shell behavior is buggy with this agreement.
> {code}
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -ls foo
> ls: Cannot access foo: No such file or directory.
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -lsr foo
> lsr: Cannot access foo: No such file or directory.
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -du foo
> du: Cannot access foo: No such file or directory.
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -dus foo
> dus: Cannot access foo: No such file or directory.
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -cp foo f2
> cp: File does not exist: foo
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -copyToLocal foo f2
> copyToLocal: null
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> statepick-lm:Hadoop rphulari$ bin/hadoop fs -copyFromLocal foo f2
> copyFromLocal: File foo does not exist.
> statepick-lm:Hadoop rphulari$ echo $?
> 255
> {code}  
> In all above cases exit code on error should be -1 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to