[ 
https://issues.apache.org/jira/browse/HADOOP-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated HADOOP-6120:
---------------------------------

    Status: Open  (was: Patch Available)

> I don't see encoder/decoder has close() method. Am I missing something?

No, it seems Avro is.  I think the contract for serializers and deserializers 
is that they can close the underlying stream.  So, until we add 
Encoder/Decoder#close() to Avro, we should explicitly save a pointer to the 
stream passed in and close it after flushing the encoder/decoder.

A few other comments.
 - AvroSerialization should be public, since public classes extend it.
 - Every public or protected method and field in public classes should have 
javadoc, unless its inherited.
 - We should add a bit more documentation at the package and class level about 
how this is to be used, e.g., explain that reflect serialization will work for 
any class that's either in the configured package list or that implements the 
tag interface, and that specific serialization will just work for generated 
classes.
 - Is there any reason not to add these serializers to io.serializations by 
default?


> Add support for Avro types in hadoop
> ------------------------------------
>
>                 Key: HADOOP-6120
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6120
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Sharad Agarwal
>            Assignee: Sharad Agarwal
>         Attachments: 6120_v1.patch, 6120_v2.patch, 6120_v3.patch, 
> 6120_v4.patch, HADOOP-6120.patch
>
>
> Support to serialize and deserialize Avro types in Hadoop.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to