[
https://issues.apache.org/jira/browse/HADOOP-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733574#action_12733574
]
Ravi Gummadi commented on HADOOP-6163:
--------------------------------------
ant tet-patch gave
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
This doesn't need a testcase as the testcase in MAPREDUCE-743 covers this code
change.
> Progress class should provide an api if phases exist
> ----------------------------------------------------
>
> Key: HADOOP-6163
> URL: https://issues.apache.org/jira/browse/HADOOP-6163
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.21.0
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-6163.patch, HADOOP-6163.v1.patch
>
>
> Progress class needs to provide an api for client to know if there are phases.
> This is needed for Task.setProgress() to decide whether to update progress of
> task or progress of current phase in the task.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
