[ 
https://issues.apache.org/jira/browse/HADOOP-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734456#action_12734456
 ] 

Giridharan Kesavan commented on HADOOP-6164:
--------------------------------------------

my bad, I mistook hdfs-458 for hdfs-450 and made the inference.

But looking the core-test console log:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/25/console

     [exec]     [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 
3.745 sec
     [exec]     [junit] Test 
org.apache.hadoop.hdfs.server.datanode.TestInterDatanodeProtocol FAILED

TestInterDatanodeProtocol test failed for some reason; and hudson while parsing 
the xml results didn't consider the test failure.

since there is a failure in the test-core ant target test-patch script gave a 
-1 for this patch for core test.

I'm not sure why hudson didn't consider this failure while generating the test 
report.
I closed this invalid b'coz I pretty much know test-patch doesn't consider the 
no of tests being run by previous and current hudson build jobs.

http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/25/testReport/org.apache.hadoop.hdfs.server.datanode/TestInterDatanodeProtocol/

If you think I'm missing something please reopen this jira.

Thanks,

> Test-patch's method of checking for new tests is not correct
> ------------------------------------------------------------
>
>                 Key: HADOOP-6164
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6164
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Giridharan Kesavan
>
> As happened in HDFS-458, test-patch/hudson saw the previous patch(HDFS-492) 
> add a new test, bringing the total number of tests to 49.  Then it tested 
> 458, which had no new tests as it was a change to the build file.  492 had 
> not yet been committed yet, so there were still only 48 tests in trunk.  But 
> test-patch failed the patch, expecting 49 tests.  test-patch should check the 
> correct number of tests based on trunk, not on whatever number it last saw.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to