[ 
https://issues.apache.org/jira/browse/HADOOP-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735884#action_12735884
 ] 

Scott Carey commented on HADOOP-6167:
-------------------------------------

Having -Xmx listed multiple times is misleading and confusing.  It should be 
listed once, preferably near the beginning.  Using tools like 'top' with the 
front of the command line printed shouldn't lie.  IMO listing things as 
important as -Xmx twice is a bad idea regardless of the actual behavior.

> bin/hadoop script doesn't allow for different memory settings for each daemon 
> type
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-6167
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6167
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Fernando
>         Attachments: hadoop, hadoop-script.diff
>
>
> bin/hadoop assumes that all daemon types ( namenode, datanode, jobtracker, 
> tasktracker ), all use the same memory settings.. (HADOOP_HEAPSIZE).
> I propose changes to that script to allow overriding the default memory ( 
> HADOOP_HEAPSIZE ), with daemon specific OPTS (HADOOP_NAMENODE_OPTS, etc ).
> Basically at the bottom of the bin/hadoop script, it will check to see if the 
> user has already set "-Xmx" in the HADOOP_OPTS variable.. if so, then it will 
> ignore the JAVA_HEAP_SIZE variable..
> as such:
> # run it
> if [[ $HADOOP_OPTS == *-Xmx* ]]; then
>   exec "$JAVA" $HADOOP_OPTS -classpath "$CLASSPATH" $CLASS "$@"
> else
>   exec "$JAVA" $JAVA_HEAP_MAX $HADOOP_OPTS -classpath "$CLASSPATH" $CLASS "$@"
> fi
> I will attach the file as I have modified it..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to