[
https://issues.apache.org/jira/browse/HADOOP-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752092#action_12752092
]
Vinod K V commented on HADOOP-6230:
-----------------------------------
I ran mapred, and contrib tests locally which have all passed.
Running `ant test-patch' got a bit trickier. I had to generate a special common
jars with only the changes to Shell.java from the common patch and copy them
over to mapred. I got all +1's except the following which are unavoidable:
{noformat}
The class name org.apache.hadoop.util.LinuxMemoryCalculatorPlugin
Nm shadows the simple name of the superclass
org.apache.hadoop.mapreduce.util.LinuxMemoryCalculatorPlugin
[5]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)
In class org.apache.hadoop.util.LinuxMemoryCalculatorPlugin
In class org.apache.hadoop.mapreduce.util.LinuxMemoryCalculatorPlugin
At LinuxMemoryCalculatorPlugin.java:[line 28]
The class name org.apache.hadoop.util.MemoryCalculatorPlugin shadows
Nm the simple name of the superclass
org.apache.hadoop.mapreduce.util.MemoryCalculatorPlugin
[6]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)
In class org.apache.hadoop.util.MemoryCalculatorPlugin
In class org.apache.hadoop.mapreduce.util.MemoryCalculatorPlugin
At MemoryCalculatorPlugin.java:[lines 32-37]
Nm The class name org.apache.hadoop.util.ProcessTree shadows the simple
name of the superclass org.apache.hadoop.mapreduce.util.ProcessTree
[7]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)
In class org.apache.hadoop.util.ProcessTree
In class org.apache.hadoop.mapreduce.util.ProcessTree
At ProcessTree.java:[line 27]
The class name org.apache.hadoop.util.ProcfsBasedProcessTree shadows
Nm the simple name of the superclass
org.apache.hadoop.mapreduce.util.ProcfsBasedProcessTree
[8]Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)
In class org.apache.hadoop.util.ProcfsBasedProcessTree
In class org.apache.hadoop.mapreduce.util.ProcfsBasedProcessTree
At ProcfsBasedProcessTree.java:[lines 28-47]
{noformat}
The mapreduce patch is committable.
> Move process tree, and memory calculator classes out of Common into
> Map/Reduce.
> -------------------------------------------------------------------------------
>
> Key: HADOOP-6230
> URL: https://issues.apache.org/jira/browse/HADOOP-6230
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Vinod K V
> Assignee: Vinod K V
> Attachments: HADOOP-6230-20090902-common.txt,
> HADOOP-6230-20090902-mapred.txt, HADOOP-6230-20090903-common.txt,
> HADOOP-6230-20090903-mapred.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
