[
https://issues.apache.org/jira/browse/HADOOP-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752419#action_12752419
]
Vinod K V commented on HADOOP-6232:
-----------------------------------
Few comments:
- HADOOP-6230 is already committed, we need a new patch that applies to mapred
project for this issue.
- I think it shouldn't be very difficult to directly test
assertAndDestroyProcessGroup()/assertPidPgrpidForMatch()
by using the concept mock processes which is already being used in
TestProcfsBasedProcessTree.
- Minor:
-- Fix the new comments/log statements introduced in this patch. They can
be bettered/made more correct.
-- Wrap around lines longer than 80 characters.
I've corrected the patch myself w.r.t HADOOP-6230 and can confirm that the NPE
messages no longer appear in
TestTaskTrackerMemoryManager with this patch.
> NPE in ProcfsBasedProcessTree.destroy()
> ---------------------------------------
>
> Key: HADOOP-6232
> URL: https://issues.apache.org/jira/browse/HADOOP-6232
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Vinod K V
> Assignee: Ravi Gummadi
> Attachments: HADOOP-6232.patch
>
>
> This causes the following exception in TaskMemoryManagerThread. I observed
> this while running TestTaskTrackerMemoryManager.
> {code}
> 2009-09-02 12:08:25,835 WARN mapred.TaskMemoryManagerThread
> (TaskMemoryManagerThread.java:run(239)) - Uncaught exception in
> TaskMemoryManager while managing memory of
> attempt_20090902120812252_0001_m_000003_0 : java.lang.NullPointerException
> at
> org.apache.hadoop.util.ProcfsBasedProcessTree.assertPidPgrpidForMatch(ProcfsBasedProcessTree.java:234)
> at
> org.apache.hadoop.util.ProcfsBasedProcessTree.assertAndDestroyProcessGroup(ProcfsBasedProcessTree.java:257)
> at
> org.apache.hadoop.util.ProcfsBasedProcessTree.destroy(ProcfsBasedProcessTree.java:286)
> at
> org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:229)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
