[
https://issues.apache.org/jira/browse/HADOOP-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757458#action_12757458
]
Kan Zhang commented on HADOOP-6271:
-----------------------------------
nits:
- In FileContextCreateMkdirBaseTest.java, ClusterShutdownAtEnd() ->
clusterShutdownAtEnd()
- In FileContext.java, extra empty line in javadoc for create()
code:
- In FileSystem.java, in primitiveCreate(), the following should throw
FileAlreadyExistsException. Same in primitiveMkdir().
{code}
+ if (!stat.isDir()) {
+ throw new FileNotFoundException("parent is not a dir:" + f);
+ }
{code}
- In FileContext#create() method, newOpts is constructed with (opts.length +1)
to accommodate a new permission option being added to opts, which means there
will be two permission options in newOpts. This will result in
IllegalArgumentException("multiple varargs of same kind") in the underlying
layer. Would it be better to construct newOpts with the same length as opts and
set the permission option in newOpts to the new one as you parse opts?
> Fix FileContext to allow both recursive and non recursive create and mkdir
> --------------------------------------------------------------------------
>
> Key: HADOOP-6271
> URL: https://issues.apache.org/jira/browse/HADOOP-6271
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: mkdirCreate1.patch, mkdirCreate2.patch,
> mkdirCreate3.patch
>
>
> Modify FileContext to allow recursive and non-recursive create and mkdir (see
> HADOOP-4952)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
