[
https://issues.apache.org/jira/browse/HADOOP-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757519#action_12757519
]
Konstantin Boudnik commented on HADOOP-6260:
--------------------------------------------
few comments:
- lot of duplicated string literals. Move them to be the class' member or
something. It also will make assertion structure smaller and easier to read
(see my comment to HADOOP-6261
- in the messages like {{Can't run test}} it makes sense to add test name -
makes it easier to analyze
- {{catch}} and {{finally}} are suppose to start next to the closing curve
bracket (in the same line, not in the next one)
Other than that it seems pretty good I think!
> Unit tests for FileSystemContextUtil.
> -------------------------------------
>
> Key: HADOOP-6260
> URL: https://issues.apache.org/jira/browse/HADOOP-6260
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Reporter: gary murry
> Assignee: gary murry
> Attachments: HADOOP-6260.patch, HADOOP-6260.patch, HADOOP-6260.patch,
> List_glob_TestPlan.html
>
>
> This Jira is to add the unit tests associated with HADOOP-4952.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
