[ 
https://issues.apache.org/jira/browse/HADOOP-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757992#action_12757992
 ] 

Konstantin Boudnik commented on HADOOP-6274:
--------------------------------------------

In the situations like this 
{noformat}
    Assert.assertTrue(getTestRootPath(TEST_DIR_AAA).equals(paths[0].getPath()) 
||
        getTestRootPath(TEST_DIR_AAA).equals(paths[1].getPath()) ||
        getTestRootPath(TEST_DIR_AAA).equals(paths[2].getPath()) ||
        getTestRootPath(TEST_DIR_AAA).equals(paths[3].getPath()));
    Assert.assertTrue(getTestRootPath(TEST_DIR_AXA).equals(paths[0].getPath()) 
||
        getTestRootPath(TEST_DIR_AXA).equals(paths[1].getPath()) ||
        getTestRootPath(TEST_DIR_AXA).equals(paths[2].getPath()) ||
        getTestRootPath(TEST_DIR_AXA).equals(paths[3].getPath()));
    Assert.assertTrue(getTestRootPath(TEST_DIR_AXX).equals(paths[0].getPath()) 
||
        getTestRootPath(TEST_DIR_AXX).equals(paths[1].getPath()) ||
        getTestRootPath(TEST_DIR_AXX).equals(paths[2].getPath()) ||
        getTestRootPath(TEST_DIR_AXX).equals(paths[3].getPath()));
    Assert.assertTrue(getTestRootPath(TEST_DIR_AAA2).equals(paths[0].getPath()) 
||
        getTestRootPath(TEST_DIR_AAA2).equals(paths[1].getPath()) ||
        getTestRootPath(TEST_DIR_AAA2).equals(paths[2].getPath()) ||
        getTestRootPath(TEST_DIR_AAA2).equals(paths[3].getPath()));
{noformat}
you'd better convert {{paths}} array into a list structure and test for 
{{contains()}} instead of testing all possible combination of the output. 
Imaging if this array will have 50 elements? :-)

> TestLocalFSFileContextMainOperations tests wrongly expect a certain order to 
> be returned.
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6274
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6274
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: gary murry
>            Assignee: gary murry
>         Attachments: HADOOP-6274.patch
>
>
> The test to be more forgiving on the return values of list status calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to