[
https://issues.apache.org/jira/browse/HADOOP-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758509#action_12758509
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6276:
------------------------------------------------
Yes, you are right that we should not make assumption about the speed of the
machine.
But sleep(..) is necessary in some cases. May be the contributor should
justify why sleep(..) is necessary in the new tests. Sounds good?
BTW, grepping "Thread.sleep(" and a "+" may not work well since there are many
ways to sleep without having "Thread.sleep(" in the codes. :D
> test-patch script should -1 patches that increase the number of
> Thread.sleep() calls in tests
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-6276
> URL: https://issues.apache.org/jira/browse/HADOOP-6276
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Nigel Daley
> Assignee: Giridharan Kesavan
>
> Calls to Thread.sleep() in tests are likely dubious. There are rare
> occasions where these are required, but in general they lead to flaky unit
> tests that fail sporadically. We used to be much better at code reviewing
> these out of patches, but have lost ground on that in the last few years (and
> our flaky unit tests show that!).
> I propose we have the test-patch script ensure that a patch does not add to
> the number of Thread.sleep() calls in *tests* by giving a -1 to patches that
> do increase it. I suggest this is a simple grep for lines containing
> "Thread.sleep(" and a "+" character in the first column.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
