[
https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764849#action_12764849
]
Jakob Homan commented on HADOOP-6204:
-------------------------------------
Patch review based on 10/12 patch:
Looks good overall with just a couple of things.
* Line 247: The TODO comment needs to be removed. The method seems
appropriately sophisticated, but if it's to be improved that should be done
either now or in a separate JIRA, but leaving the comment in the code won't
work.
* Line 273: If may be useful to log if an invalid property has been specified
in the config file.
* The new target injectfaults doesn't follow the convention of separating words
with a hyphen.
Nits:
* Lines 132 and 151, what's the point of the empty space within the comments?
* Line 321-326, is it necessary to have init be a separate method rather than
inlining into the static block from which it is called I'm not seeing the
purpose of the separate method.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch,
> HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch,
> HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a
> very useful feature both for error handling testing and for various
> simulations.
> There's certain demand for this framework, thus it need to be pulled up from
> HDFS and brought into Common, so other sub-projects will be able to share it
> if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
