[ 
https://issues.apache.org/jira/browse/HADOOP-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765245#action_12765245
 ] 

Todd Lipcon commented on HADOOP-6241:
-------------------------------------

Couple small notes:
- ./bin/split_config.py shows nice usage information including the same 
invocation. split_config.py --help lacks the __doc__ info which I found 
helpful. Can you convince OptionParser to print that for all usage notices?
- In dist releases, the -default.xml files don't exist. If we expect this to be 
useful for users and not just developers, it should be able to look inside the 
jars for the -default.xml files. Since jars are just zips, you can probably do 
this pretty easily using the zipfile module.

Aside from that, looks good. Sorry I didn't think about the -default thing on 
the first pass through.

> Script to split configurations from one file into multiple, according to 
> templates.
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-6241
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6241
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Philip Zeyliger
>         Attachments: HADOOP-6241-v2.patch.txt, HADOOP-6241-v3.patch.txt, 
> HADOOP-6241.patch.txt
>
>
> This script moves properties from hadoop-site.xml into common-site, 
> mapred-site, and hdfs-site in a reasonably generic way.  This is useful for 
> upgrading clusters from 0.18 to 0.20 and 0.21.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to