[
https://issues.apache.org/jira/browse/HADOOP-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789553#action_12789553
]
Todd Lipcon commented on HADOOP-6433:
-------------------------------------
Hey Zheng,
Looks mostly good. Couple nits I missed in the first review (sorry about that!)
- Comment in ExampleTask says "A task for deleting a pathName", but that's a
copy-paste
- "@throws Throwable" in the javadoc is not necessary
- In awaitTermination() you could end up calling awaitTermination with a
negative argument. I imagine this will probably throw an
IllegalArgumentException or something. You should do Math.max(end -
System.currentTimeMillis(), 0) I guess.
- Is warn level logging appropriate for "All AsyncDiskService threads are
terminated"? Seems like info, not warn.
Thanks!
> Add AsyncDiskService that is used in both hdfs and mapreduce
> ------------------------------------------------------------
>
> Key: HADOOP-6433
> URL: https://issues.apache.org/jira/browse/HADOOP-6433
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HADOOP-6433.1.patch, HADOOP-6433.2.patch
>
>
> Both MAPREDUCE-1213 and HDFS-611 are using a class called AsyncDiskService.
> The idea is to create a thread pool per disk volume, and use that for
> scheduling async disk operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
