[
https://issues.apache.org/jira/browse/HADOOP-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791563#action_12791563
]
Jakob Homan commented on HADOOP-4656:
-------------------------------------
Reviewed v6 of patch:
* It may be a good idea to explicitly document that getGroups (both in
GroupMappingServiceProvider and Groups) will return an empty list for a
non-existent user. This avoids any future null-related confusion.
* Comment on RefreshUserToGroupMappingProtocol seems incomplete
* "just return the emptly list" - empty spelled incorrectly
* The change to the exception message in setUserGroupNames no longer reflects
the fact that userName shouldn't be a zero-length string
* In TestUnixUserGroupInformation, {code}testConstructorFailures(USER_NAME, new
String[0]); // valid case now{code} is commented out, and should be removed.
* In the negative test, an extra assert that getPrincipals is zero-length
wouldn't hurt.
* {code}fail("fakeUser should have no grups");{code} - groups is spelled
incorrectly
> Add a user to groups mapping service
> -------------------------------------
>
> Key: HADOOP-4656
> URL: https://issues.apache.org/jira/browse/HADOOP-4656
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.19.0
> Reporter: Arun C Murthy
> Assignee: Boris Shkolnik
> Attachments: HADOOP-4656-1.patch, HADOOP-4656-2.patch,
> HADOOP-4656-4.patch, HADOOP-4656-6.patch, HADOOP-4656-6.patch,
> HADOOP-4656.patch, HADOOP-4656_0_20090108.patch
>
>
> Currently the IPC client sends the UGI which contains the user/group
> information for the Server. However this represents the groups for the user
> on the client-end. The more pertinent mapping from user to groups is actually
> the one seen by the Server. Hence the client should only send the user and we
> should add a 'group mapping service' so that the Server can query it for the
> mapping.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
