[
https://issues.apache.org/jira/browse/HADOOP-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794203#action_12794203
]
Todd Lipcon commented on HADOOP-4998:
-------------------------------------
Specific comments:
- In executeShellCommand, you refer to "groups" even though this is no longer
groups-specific. I also think it's strange that this generic command
automatically splits on whitespace for the caller - why not just return String,
and then have them use String.split if they want?
- Instead of defining toString in this class, you can use
o.a.h.util.StringUtil.join, right?
- In PlatformCall.c, do you need to actually check the HAVE_FOO_H definitions?
Seems to me that the compiler will itself give you the error, no need to #error
- sysconf(3) doesn't list GETPW_R_SIZE_MAX as POSIX compliant and some googling
leads me to believe it might not be supported on FreeBSD, which I think is
useful to Y!. If we provide a too-small buffer, we'll get ERANGE and can just
try again with a larger one until we stop getting that error.
- If getpwuid_r returns non-zero, should we raise an exception rather than
returning null?
Less specific: thoughts on making this into an interface, with an
implementation for JniPlatformCall and ShellPlatformCall? This may be handy if
someone wants to come along and implement WindowsPlatformCall or
SolarisShellPlatformCall, etc.
> Implement a native OS runtime for Hadoop
> ----------------------------------------
>
> Key: HADOOP-4998
> URL: https://issues.apache.org/jira/browse/HADOOP-4998
> Project: Hadoop Common
> Issue Type: New Feature
> Components: native
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.21.0
>
> Attachments: hadoop-4998-1.patch
>
>
> It would be useful to implement a JNI-based runtime for Hadoop to get access
> to the native OS runtime. This would allow us to stop relying on exec'ing
> bash to get access to information such as user-groups, process limits etc.
> and for features such as chown/chgrp (org.apache.hadoop.util.Shell).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
