[
https://issues.apache.org/jira/browse/HADOOP-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794434#action_12794434
]
Hadoop QA commented on HADOOP-3457:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428914/HADOOP-3457.patch
against trunk revision 893666.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/238/console
This message is automatically generated.
> IPC.Client retry delay could be made configurable
> -------------------------------------------------
>
> Key: HADOOP-3457
> URL: https://issues.apache.org/jira/browse/HADOOP-3457
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-3457.patch, HADOOP-3457.patch
>
>
> The delay of ipc.Client.handleConnectionFailure() that causes the client to
> block and wait is hard coded at 1 second; any interruption of the thread is
> treated as a shortening of the delay.
> // otherwise back off and retry
> try {
> Thread.sleep(1000);
> } catch (InterruptedException ignored) {}
>
> 1. this delay could be configurable; different clients may wish to retry
> more/less often. or at a slightly different rate than their peers.
> 2. interrupting the thread may imply the client has been requested to
> terminate -this could be handled by declaring failure early, rather than
> continuing to retry until the retry count is exceeded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
