[ 
https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795023#action_12795023
 ] 

Devaraj Das commented on HADOOP-6472:
-------------------------------------

Looks good. Some minor comments:
1) Remove the LOG.info calls 
2) There seems to be an unused import in the testcase 
(org.apache.hadoop.record.Utils). 
3) Some unnecessary whitespace changes in the testcase.
4) Maybe we should rename the "tokenCache" option to "tokenCacheFile" to make 
it more specific that it needs to be a file..

> add tokenCache option to GenericOptionsParser for passing file with secret 
> keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6472
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6472
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) 
> to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to