[ 
https://issues.apache.org/jira/browse/HADOOP-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806214#action_12806214
 ] 

Hadoop QA commented on HADOOP-6397:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431738/HADOOP-6397-v2.patch
  against trunk revision 904339.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/298/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/298/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/298/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/298/console

This message is automatically generated.

> topology script called with host names instead of IP addresses
> --------------------------------------------------------------
>
>                 Key: HADOOP-6397
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6397
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.22.0
>            Reporter: Christian Kunz
>         Attachments: HADOOP-6397-v2.patch, HADOOP-6397.patch
>
>
> According to the 'Hadoop Rack Awareness' section on 
> http://hadoop.apache.org/common/docs/r0.20.0/cluster_setup.html the 
> script/program topology.script.file.name can assume that names are passed in 
> as IP addresses.
> This seems to work for hdfs, but the rack-awareness of the JobTracker does 
> not always work, depending on the hostnames of the cluster, because of a bug 
> in the method normalizeHostName of org.apache.hadoop.net.NetUtils.java:
> It returns the host name as-is when it decides that the string passed-in is 
> already an IP but actually it checks whether the string starts with a valid 
> hex character!
> There is no need to check at all, because InetAddress.getByName is smart 
> enough to not do a dns lookup when the name is an IP address.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to