[
https://issues.apache.org/jira/browse/HADOOP-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806641#action_12806641
]
Owen O'Malley commented on HADOOP-6419:
---------------------------------------
Comments:
1. Please keep the lines to 80 characters.
2. Change the new testcase to Junit 4 annotations.
3. TokenInfo needs more documentation on the intended purpose of the class.
4. SaslRpcClient shouldn't implement SaslClient and forward the calls to the
contained SaslClient.
5. SaslOutputStream (and SaslInutStream).disposeSasl shouldn't throw away
exceptions because in the non-error case exceptions could be important. The
cases where disposeSasl is called while handling an exception should ignore
IOErrors from dispose.
I agree with Doug that you've done a great job of minimizing the impact on the
RPC code.
> Change RPC layer to support SASL based mutual authentication
> ------------------------------------------------------------
>
> Key: HADOOP-6419
> URL: https://issues.apache.org/jira/browse/HADOOP-6419
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6419-26.patch, c6419-39.patch, c6419-45.patch,
> c6419-66.patch, c6419-67.patch
>
>
> The authentication mechanism to use will be SASL DIGEST-MD5 (see RFC-2222 and
> RFC-2831) or SASL GSSAPI/Kerberos. Since J2SE 5, Sun provides a SASL
> implementation by default. Both our delegation token and job token can be
> used as credentials for SASL DIGEST-MD5 authentication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
