[ 
https://issues.apache.org/jira/browse/HADOOP-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837092#action_12837092
 ] 

Sanjay Radia commented on HADOOP-6537:
--------------------------------------

* AbstractFileSystem
** createFileSystem - you removed the javadoc for the args.
** fix the spelling error:   throw new HadoopIllegalArgumentException("Unkown 
CreateOpts of type " +
** createInternal -  missing  FileNotFoundException, ParentNotDirectory
** create, mkdir - missing  ParentNotDirectory
** getFileLinkStatus - missing FileNotFoundException
** setVerifyChecksum - should not throw FileNotFoundException

* FileContext
** getFileLinkStatus and getLinkTarget - missing FileNotFoundException, 
AccessDeniesEx, FileSystemNotSupportedEx
** mkdir - javadoc, ist line:
*** "Make the given file and all non-existent parents into directories."
     Change to 
*** "Make(create) a directory"
** createSymlink - missing detailed exceptions - same as create.
** exists(f)  - should it return false instead of 
UnsupportedFileSystemException?
** getContentSummary, listStatus(all variations), globStatus(??) - add the 
UnresolvedLinkE
** copy - ParentNotDir, FileNotFound, UnresolvedLinkE

> Proposal for exceptions thrown by FileContext and Abstract File System
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6537
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6537
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jitendra Nath Pandey
>            Assignee: Suresh Srinivas
>             Fix For: 0.22.0
>
>         Attachments: hdfs-717.1.patch, hdfs-717.2.patch, hdfs-717.3.patch, 
> hdfs-717.patch, hdfs-717.patch
>
>
> Currently the APIs in FileContext throw only IOException. Going forward these 
> APIs will throw more specific exceptions.
> This jira proposes following hierarchy of exceptions to be thrown by 
> FileContext and AFS (Abstract File System) classes.
> InterruptedException  (java.lang.InterruptedException)
> IOException
>                 /* Following exceptions extend IOException */
>                 FileNotFoundException
>                 FileAlreadyExistsException
>                 DirectoryNotEmptyException
>                 NotDirectoryException
>                 AccessDeniedException
>                 IsDirectoryException
>                 InvalidPathNameException
>                 
>                 FileSystemException
>                                      /* Following exceptions extend 
> FileSystemException */
>                                      FileSystemNotReadyException
>                                      ReadOnlyFileSystemException
>                                      QuotaExceededException
>                                      OutOfSpaceException
>                 RemoteException   (java.rmi.RemoteException)
> Most of the IOExceptions above are caused by invalid user input, while 
> FileSystemException is thrown when FS is in such a state that the requested 
> operation cannot proceed.
> Please note that the proposed RemoteException is from standard java rmi 
> package, which also extends IOException.
>                             
> HDFS throws many exceptions which are not in the above list. The DFSClient 
> will unwrap the exceptions thrown by HDFS, and any exception not in the above 
> list will be thrown as IOException or FileSystemException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to