[
https://issues.apache.org/jira/browse/HADOOP-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837481#action_12837481
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6566:
------------------------------------------------
Patch looks mostly good. Some suggestions:
- In DiskChecker, how about combining mkdirsWithExistsCheck(..) and
checkDir(..) into a method?
- I think it is better eliminate to DiskChecker.checkPermission(..) so that we
could avoid a public method. Otherwise, it will mutate and become something
completely different in the future. In the tests, we could just use
assertEquals(..).
- You may use FsAction.READ_WRITE, instead of both FsAction.READ and
FsAction.WRITE.
- Need javadoc for the public methods.
> Hadoop daemons should not start up if the ownership/permissions on the
> directories used at runtime are misconfigured
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6566
> URL: https://issues.apache.org/jira/browse/HADOOP-6566
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Devaraj Das
> Assignee: Arun C Murthy
> Fix For: 0.22.0
>
> Attachments: HADOOP-6566_yhadoop20.patch,
> HADOOP-6566_yhadoop20.patch, HADOOP-6566_yhadoop20.patch
>
>
> The Hadoop daemons (like datanode, namenode) should refuse to start up if the
> ownership/permissions on directories they use at runtime are misconfigured or
> they are not as expected. For example, the local directory where the
> filesystem image is stored should be owned by the user running the namenode
> process and should be only readable by that user. We can provide this feature
> in common and HDFS and MapReduce can use the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
