[ 
https://issues.apache.org/jira/browse/HADOOP-6722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860632#action_12860632
 ] 

Hadoop QA commented on HADOOP-6722:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442761/hadoop-6722.txt
  against trunk revision 937577.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/478/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/478/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/478/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/478/console

This message is automatically generated.

> NetUtils.connect should check that it hasn't connected a socket to itself
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6722
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6722
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6722.txt
>
>
> I had no idea this was possible, but it turns out that a TCP connection will 
> be established in the rare case that the local side of the socket binds to 
> the ephemeral port that you later try to connect to. This can present itself 
> in very very rare occasion when an RPC client is trying to connect to a 
> daemon running on the same node, but that daemon is down. To see what I'm 
> talking about, run "while true ; do telnet localhost 60020 ; done" on a 
> multicore box and wait several minutes.
> This can be easily detected in NetUtils.connect by making sure the local 
> address/port is not equal to the remote address/port.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to