[
https://issues.apache.org/jira/browse/HADOOP-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872745#action_12872745
]
Hadoop QA commented on HADOOP-6585:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445723/hadoop-6585-5.patch
against trunk revision 949032.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 23 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/552/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/552/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/552/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/552/console
This message is automatically generated.
> Add FileStatus#isDirectory and isFile
> -------------------------------------
>
> Key: HADOOP-6585
> URL: https://issues.apache.org/jira/browse/HADOOP-6585
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6585-1.patch, hadoop-6585-2.patch,
> hadoop-6585-3.patch, hadoop-6585-4.patch, hadoop-6585-5.patch
>
>
> Per Sanjay's suggestion in HADOOP-6421 let's deprecate FileStatus#isDir() and
> add isDirectory() and isFile() to compliment isSymlink. Currently clients
> assume !isDir() implies a file, which is no longer true with symlinks. I'll
> file a separate jira to change the various uses of !isDir() to be isFile() or
> isFile() or isSymlink() as appropriate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
