[ 
https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874763#action_12874763
 ] 

Jakob Homan commented on HADOOP-6796:
-------------------------------------

Rodrigo: any constructor that converts an empty path to "/" is a change in 
behavior that we're not going to introduce. Again, from above and from what Eli 
said, Writable is fundamentally a flawed and dangerous data structure if you're 
expecting it to guarantee any integrity to its fields.  Checking for not null 
on other constructors is fine, I guess; are we also going to verify that the 
constituent long fields are non-negative? And yeah, go ahead and throw in 
asserts - they're our best bet of catching logic errors in this data structure 
during unit tests.

> FileStatus allows null srcPath but crashes if that's done
> ---------------------------------------------------------
>
>                 Key: HADOOP-6796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6796
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6796.patch
>
>
> FileStatus allows constructor invocation with a null srcPath but many methods 
> like write, readFields, compareTo, equals, and hashCode depend on this 
> property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to