[
https://issues.apache.org/jira/browse/HADOOP-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878843#action_12878843
]
Hadoop QA commented on HADOOP-6746:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org
against trunk revision 954647.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/584/console
This message is automatically generated.
> hadoop-daemon.sh does not append to log files
> ---------------------------------------------
>
> Key: HADOOP-6746
> URL: https://issues.apache.org/jira/browse/HADOOP-6746
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Travis Crawford
> Attachments: HADOOP-6746.patch
>
>
> Looking in hadoop-daemon.sh we see the start command redirects logs to the
> log file by creating a new file. It does not append to the log.
> nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config
> $HADOOP_CONF_DIR $command "$@" > "$log" 2>&1 < /dev/null &
> I believe output should be appended to the log file so logrotate copytruncate
> works. Currently a large log file cannot be truncated without restarting the
> running service, which causes issues in production environments.
> The improved line would be exactly the same, except use >> to open the log
> file in append mode.
> nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config
> $HADOOP_CONF_DIR $command "$@" >> "$log" 2>&1 < /dev/null &
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
