[
https://issues.apache.org/jira/browse/HADOOP-12601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027562#comment-15027562
]
Wei-Chiu Chuang commented on HADOOP-12601:
------------------------------------------
And it's interesting the pre-commit for the patch has a findbugs warning for
the unused local variable, even though I removed the local variable in the
patch.
> findbugs highlights problem with FsPermission
> ---------------------------------------------
>
> Key: HADOOP-12601
> URL: https://issues.apache.org/jira/browse/HADOOP-12601
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, io
> Affects Versions: 3.0.0
> Environment: yetus
> Reporter: Steve Loughran
>
> Findbugs is warning of a problem in {{FsPermission}}
> {code}
> n class org.apache.hadoop.fs.permission.FsPermission
> In method org.apache.hadoop.fs.permission.FsPermission.getUMask(Configuration)
> Local variable named oldUmask
> At FsPermission.java:[line 249]
> {code}
> This may actually be a sign of a bug in the code, but as it's reading a key
> tagged as deprecated since 2010 and to be culled in 0.23, maybe cutting the
> line is the strategy. After all, if the code has been broken, and nobody
> complained, that deprecation worked
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
