[
https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895830#action_12895830
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6897:
------------------------------------------------
Map/Reduce could just replace it with two or three lines of codes.
I forgot to mention that there is another drawback about the static mkdir(..).
Some users calling it do not realize that it is actually more expensive
compared with the non-static mkdir(..) -- it requires one more rpc calls.
> FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call
> setPermission if mkdirs failled
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6897
> URL: https://issues.apache.org/jira/browse/HADOOP-6897
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: mkdirs.patch
>
>
> Here is the piece of code that has the bug. fs.setPermission should not be
> called if result is false.
> {code}
> public static boolean mkdirs(FileSystem fs, Path dir, FsPermission
> permission)
> throws IOException {
> // create the directory using the default permission
> boolean result = fs.mkdirs(dir);
> // set its permission to be the supplied one
> fs.setPermission(dir, permission);
> return result;
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
