[
https://issues.apache.org/jira/browse/HADOOP-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Templeton updated HADOOP-12546:
--------------------------------------
Attachment: HADOOP-12546.002.patch
[~stevel], I extended {{GenericTestUtils}} to allow for a multi-string
exception message check, since that's most of what I am testing in the test
class. There were still a couple of cases where the logic was too complicated
to offload, but I did switch those cases to using {{toString()}} instead of
{{getMessage()}}.
> Improve TestKMS
> ---------------
>
> Key: HADOOP-12546
> URL: https://issues.apache.org/jira/browse/HADOOP-12546
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 2.7.1
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: HADOOP-12546.001.patch, HADOOP-12546.002.patch
>
>
> The TestKMS class has some issues:
> * It swallows some exceptions' stack traces
> * It swallows some exceptions altogether
> * Some of the tests aren't as tight as they could be
> * Asserts lack messages
> * Code style is a bit hodgepodge
> This JIRA is to clean all that up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
