[
https://issues.apache.org/jira/browse/HADOOP-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042418#comment-15042418
]
Lei (Eddy) Xu commented on HADOOP-12537:
----------------------------------------
Hi, [~mackrorysd] Thanks a lot for working on this.
{code}
private static final String TEST_STS_ENDPOINT = "tst.sts.endpoint";
{code}
Could you fix the typo in the string?
{code}
@Before
public void checkSettings() throws Exception {
conf = new Configuration();
assumeNotNull(conf.get(TEST_STS_ENABLED));
testDir = new Path(TEST_DIR);
}
{code}
Would it be ok to rename this function to {{setUp()}} to be consistent to the
rest of the code. Should {{TEST_STS_ENABLED}} has a boolean value? does it
have a default value? One more question regarding this boolean value: should
this test be enabled when all S3a tests are enabled? Is there any circumstances
that we want to enable either STS or the rest of S3A tests?
{code}
useSessionToken(
sessionCreds.getAccessKeyId(),
sessionCreds.getSecretAccessKey(),
sessionCreds.getSessionToken());
assertTrue("Verifying test directory was made: ", fs.exists(testDir));
{code}
Would you put {{fs.exists(..)}} and {{fs.mkdirs()}} into the same function?
Last, is marking the functions throwing {{IOException}} sufficient, instead of
Exception?
The rest LTGM. I'd give +1 once the above are addressed.
> s3a: Add flag for session ID to allow Amazon STS temporary credentials
> ----------------------------------------------------------------------
>
> Key: HADOOP-12537
> URL: https://issues.apache.org/jira/browse/HADOOP-12537
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/s3
> Affects Versions: 2.7.1
> Reporter: Sean Mackrory
> Priority: Minor
> Attachments: HADOOP-12537.001.patch, HADOOP-12537.diff,
> HADOOP-12537.diff
>
>
> Amazon STS allows you to issue temporary access key id / secret key pairs for
> your a user / role. However, using these credentials also requires specifying
> a session ID. There is currently no such configuration property or the
> required code to pass it through to the API (at least not that I can find) in
> any of the S3 connectors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
