[ 
https://issues.apache.org/jira/browse/HADOOP-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063117#comment-15063117
 ] 

Arpit Agarwal commented on HADOOP-12570:
----------------------------------------

Hi [~cnauroth], thanks for the review!

bq. The descriptions in hdfs-default.xml are nice to have, but I'm concerned 
that they are not backwards-compatible.
There should be no incompatibility introduced by the patch. It just fixes wrong 
documentation to be in line with the code. e.g. 
{{dfs.namenode.kerberos.internal.spnego.principal}} has no default in code but 
it was documented as defaulting to 
{{dfs.web.authentication.kerberos.principal}} in hdfs-default.xml. From 
{{NameNodeHttpServer#start}}:

{code}
    HttpServer2.Builder builder = DFSUtil.httpServerTemplateForNNAndJN(conf,
        httpAddr, httpsAddr, "hdfs",
        DFSConfigKeys.DFS_NAMENODE_KERBEROS_INTERNAL_SPNEGO_PRINCIPAL_KEY,
        DFSConfigKeys.DFS_NAMENODE_KEYTAB_FILE_KEY);
{code}

A few unit tests broke after this patch because they were pulling 
{{hdfs-default.xml}} as a resource and depending on the incorrect defaults 
instead of initializing their own test configuration correctly.

I'll post an updated patch addressing the remaining feedback.

> HDFS Secure Mode Documentation updates
> --------------------------------------
>
>                 Key: HADOOP-12570
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12570
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 2.7.1
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-9254.01.patch, HDFS-9254.02.patch, 
> HDFS-9254.03.patch, HDFS-9254.04.patch
>
>
> Some Kerberos configuration parameters are not documented well enough. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to