[
https://issues.apache.org/jira/browse/HADOOP-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063181#comment-15063181
]
Kai Zheng commented on HADOOP-11996:
------------------------------------
Thanks Colin for the helpful comments!
bq. Why duplicate this file? Should we just replace the old test with the new,
if it is better?
The old test was almost a duplicate from ISA-L codes and its purpose was to
test the thin wrapping of the library and building correctness. This new test
is supposed to test the codes introduced here, which provide higher level
constructs for the eventual ISA-l coder (in HADOOP-11540) to use. The two tests
overlap partly, but I thought it's a good idea to use the new one to replace
the old, because the new one can cover the main purpose of the old, and
complete testing of the library isn't necessary in Hadoop side.
Your other comments also sound great, and I will do that as you suggested.
> Native erasure coder facilities based on ISA-L
> ----------------------------------------------
>
> Key: HADOOP-11996
> URL: https://issues.apache.org/jira/browse/HADOOP-11996
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11996-initial.patch, HADOOP-11996-v2.patch,
> HADOOP-11996-v3.patch, HADOOP-11996-v4.patch
>
>
> While working on HADOOP-11540 and etc., it was found useful to write the
> basic facilities based on Intel ISA-L library separately from JNI stuff. It's
> also easy to debug and troubleshooting, as no JNI or Java stuffs are involved.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
