[
https://issues.apache.org/jira/browse/HADOOP-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063656#comment-15063656
]
Xiao Chen commented on HADOOP-12605:
------------------------------------
bq. There is a chance for additional connections to be taken out of
pendingConnections before reader blocks on the second message from the clients.
Makes sense to me. I didn't catch this part. Strictly speaking, this is a flaw
in the reader, rather than a flaky test. But IMO this is fine and we can just
update the test to make sure we don't run into it. Also thanks for the
debugging log - I tried locally to run thousands of times, but never had it
fail!
The new approach looks better. Making the callQueue to be protected brings up a
new check style warning though, not sure what's the best practice here. Another
minor comment is to update the comment in test after " // let subsequent
readers jam the callq, will happen immediately ". I've tested locally that
patch 2 passes. Thanks a lot for the work and analysis, [~iwasakims].
> Fix intermittent failure of TestIPC.testIpcWithReaderQueuing
> ------------------------------------------------------------
>
> Key: HADOOP-12605
> URL: https://issues.apache.org/jira/browse/HADOOP-12605
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HADOOP-12605.001.patch, HADOOP-12605.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
