Tianyin Xu created HADOOP-12671:
-----------------------------------
Summary: Inconsistent configuration values and incorrect comments
Key: HADOOP-12671
URL: https://issues.apache.org/jira/browse/HADOOP-12671
Project: Hadoop Common
Issue Type: Bug
Components: conf, documentation, fs/s3
Affects Versions: 2.6.2, 2.7.1
Reporter: Tianyin Xu
The two values in [core-default.xml |
https://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/core-default.xml]
are wrong.
{{fs.s3a.multipart.purge.age}}
{{fs.s3a.connection.timeout}}
{{fs.s3a.connection.establish.timeout}}
\\
\\
*1. {{fs.s3a.multipart.purge.age}}*
(in both {{2.6.2}} and {{2.7.1}})
In [core-default.xml |
https://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/core-default.xml],
the value is {{86400}} ({{24}} hours), while in the code it is {{14400}}
({{4}} hours).
\\
\\
*2. {{fs.s3a.connection.timeout}}*
(only appear in {{2.6.2}})
In [core-default.xml (2.6.2) |
https://hadoop.apache.org/docs/r2.6.2/hadoop-project-dist/hadoop-common/core-default.xml],
the value is {{5000}}, while in the code it is {{50000}}.
{code}
// seconds until we give up on a connection to s3
public static final String SOCKET_TIMEOUT = "fs.s3a.connection.timeout";
public static final int DEFAULT_SOCKET_TIMEOUT = 50000;
{code}
\\
*3. {{fs.s3a.connection.establish.timeout}}*
(only appear in {{2.7.1}})
In [core-default.xml (2.7.1)|
https://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/core-default.xml],
the value is {{5000}}, while in the code it is {{50000}}.
{code}
// seconds until we give up trying to establish a connection to s3
public static final String ESTABLISH_TIMEOUT =
"fs.s3a.connection.establish.timeout";
public static final int DEFAULT_ESTABLISH_TIMEOUT = 50000;
{code}
\\
btw, the code comments are wrong! The two parameters are in the unit of
*milliseconds* instead of *seconds*...
{code}
- // seconds until we give up on a connection to s3
+ // milliseconds until we give up on a connection to s3
...
- // seconds until we give up trying to establish a connection to s3
+ // milliseconds until we give up trying to establish a connection to s3
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
