[
https://issues.apache.org/jira/browse/HADOOP-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070689#comment-15070689
]
Kai Zheng commented on HADOOP-12658:
------------------------------------
About IOException, there was a comment [here |
https://issues.apache.org/jira/browse/HDFS-8562?focusedCommentId=15068512&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15068512]
in HDFS-8562 I forgot to address:
bq. SocketTimeoutException is timeouts, other IOExceptions could be other
things. Maybe have two lines about exceptions, one for IOE and another for
timeout?
{{SocketTimeoutException}} is also an {{IOException}}. Having the both in the
throw list would not look clean. Not adding SocketTimeoutException explicitly
doesn't prevent callers from handling it specially. If we'd like to add
SocketTimeoutException in the {{accept()}} method throw list, we might need to
do it as well for other methods. More suggestions are welcome.
> Clear javadoc and check style issues around DomainSocket
> --------------------------------------------------------
>
> Key: HADOOP-12658
> URL: https://issues.apache.org/jira/browse/HADOOP-12658
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Priority: Trivial
> Attachments: HADOOP-12658-v1.patch, HADOOP-12658-v2.patch,
> HADOOP-12658-v3.patch
>
>
> It was noticed Javadoc needs minor udpate in {{DomainSocket}}.
> There are some other check style issues around to clear up found when working
> on HDFS-8562.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
