[
https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kai Zheng updated HADOOP-12662:
-------------------------------
Attachment: HADOOP-12662-v3.patch
Updated the patch to:
* Used bash and {{set -o pipefail}} to check error as [~cmccabe] suggested;
* Refactored the script codes adding a function to bundle a native library;
* Fixed some minor issues related to bundling ISA-L found during the work.
As to splitting the script codes out of {{pom.xml}}, it looks like there isn't
obvious way to put the script file somewhere and reference it in the pom file,
I suggest we consider the change separately. We may reconsider some basic
approach for it according to somewhat best practice in *Maven* projects. After
some experimenting, putting it in the {{dev-support}} folder looks like doesn't
work elegantly.
> The build should fail if a -Dbundle option fails
> ------------------------------------------------
>
> Key: HADOOP-12662
> URL: https://issues.apache.org/jira/browse/HADOOP-12662
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch,
> HADOOP-12662-v3.patch
>
>
> Per some discussion with [~cmccabe], it would be good to refine and make it
> consistent the behaviors in bundling native libraries when building dist
> package.
> For all native libraries to bundle, if the bundling option like
> {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}}
> will be checked and ensured to be there, but if not, it will then report
> error and fail the building explicitly.
> {{BUILDING.txt}} would also be updated to explicitly state this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
