[ 
https://issues.apache.org/jira/browse/HADOOP-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-12356:
-----------------------------------
    Hadoop Flags: Reviewed

I am also +1 for v8.

I have just one other minor note.  {{SysInfo}} is annotated {{Public}} and 
{{Evolving}}.  I prefer the clearer naming in patch v8, but changing the method 
name is backwards-incompatible.  We're within our compatibility policy to do 
that on a minor release line, so it's fine for 2.8.0, but it cannot be 
backported to any prior maintenance lines.  As long as we're fine with that 
limitation, I remain +1.

[~leftnoteasy], I'd appreciate if you could do the commit, given that this 
touches a bit of YARN code that you're more familiar with.

> CPU usage statistics on Windows
> -------------------------------
>
>                 Key: HADOOP-12356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12356
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>         Environment: CPU: Intel Xeon
> OS: Windows server
>            Reporter: Yunqi Zhang
>            Assignee: Inigo Goiri
>              Labels: easyfix, newbie, patch
>         Attachments: 0001-Correct-the-CPU-usage-calcualtion.patch, 
> 0001-Correct-the-CPU-usage-calcualtion.patch, HADOOP-12356-v3.patch, 
> HADOOP-12356-v4.patch, HADOOP-12356-v5.patch, HADOOP-12356-v6.patch, 
> HADOOP-12356-v7.patch, HADOOP-12356-v8.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The CPU usage information on Windows is computed incorrectly. The proposed 
> patch fixes the issue, and unifies the the interface with Linux.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to