[
https://issues.apache.org/jira/browse/HADOOP-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124583#comment-15124583
]
Zhe Zhang commented on HADOOP-12668:
------------------------------------
Thanks Vijay for updating the patch. Agreed that Jenkins seems broken in the
last run. I just triggered again.
A few comments about the test:
# In {{TestSSLHttpServer#testExcludedCiphers}}, even with an empty
{{excludeCiphers}}, the test will pass. Is {{getDefaultCipherSuites}} the right
method to use?
# Javadoc of {{testExcludedCiphers}} shouldn't include empty/trivial {{return}}
and {{throws}} annotations.
# The below double loop can be replaced with a hash map lookup to make sure
there's no overlap.
{code}
for(String excludedCipher : excludedCiphers) {
for (String availableCipher : availableCiphers) {
{code}
# Tyop "execluded"
> Modify HDFS embeded jetty server logic in HttpServer2.java to exclude weak
> Ciphers through ssl-server.conf
> ----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12668
> URL: https://issues.apache.org/jira/browse/HADOOP-12668
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 2.7.1
> Reporter: Vijay Singh
> Assignee: Vijay Singh
> Priority: Critical
> Labels: common, ha, hadoop, hdfs, security
> Attachments: Hadoop-12668.006.patch, Hadoop-12668.007.patch, test.log
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently Embeded jetty Server used across all hadoop services is configured
> through ssl-server.xml file from their respective configuration section.
> However, the SSL/TLS protocol being used for this jetty servers can be
> downgraded to weak cipher suites. This code changes aims to add following
> functionality:
> 1) Add logic in hadoop common (HttpServer2.java and associated interfaces) to
> spawn jetty servers with ability to exclude weak cipher suites. I propose we
> make this though ssl-server.xml and hence each service can choose to disable
> specific ciphers.
> 2) Modify DFSUtil.java used by HDFS code to supply new parameter
> ssl.server.exclude.cipher.list for hadoop-common code, so it can exclude the
> ciphers supplied through this key.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
