[
https://issues.apache.org/jira/browse/HADOOP-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Chen updated HADOOP-12699:
-------------------------------
Attachment: HADOOP-12699.09.patch
Thanks a lot [~andrew.wang] for the additional review, and educations on
javadoc!
Patch 9 fixes the javadocs, and adds the documents into the {{index.md.vm}}.
Please see if the English I put in there are understandable and reasonable to
you.
P.S. I've googled, but didn't find how to compile the docs. How do you usually
check the docs' format? I'm using a plugin in my IDE, but would love to double
check in a browser somehow. (I wanted to put the link to expireAfterAccess to
be more accurate, but since the link has brackets in it the md doesn't seem to
work with it
"http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/cache/CacheBuilder.html#expireAfterAccess(long,
java.util.concurrent.TimeUnit)")
Also, looks to me the test uses {{KMSClientProvider}} too, and
{{CryptoExtension}} is an interface. I verified by debugging, I can step in
TestKMS -> LoadBalancingKMSClientProvider -> KMSClientProvider... So I modified
the test to expect rollover to be observable after both caches are drain.
(Still weird that disabling the async on EagerKGKPCE along would pass the
test.... maybe it's just low probability?) Please correct me if I misunderstood.
Thanks again!
> TestKMS#testKMSProvider intermittently fails during 'test rollover draining'
> ----------------------------------------------------------------------------
>
> Key: HADOOP-12699
> URL: https://issues.apache.org/jira/browse/HADOOP-12699
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-12699.01.patch, HADOOP-12699.02.patch,
> HADOOP-12699.03.patch, HADOOP-12699.04.patch, HADOOP-12699.06.patch,
> HADOOP-12699.07.patch, HADOOP-12699.08.patch, HADOOP-12699.09.patch,
> HADOOP-12699.repro.2, HADOOP-12699.repro.patch
>
>
> I've seen several failures of testKMSProvider, all failed in the following
> snippet:
> {code}
> // test rollover draining
> KeyProviderCryptoExtension kpce = KeyProviderCryptoExtension.
> createKeyProviderCryptoExtension(kp);
> .....
> EncryptedKeyVersion ekv1 = kpce.generateEncryptedKey("k6");
> kpce.rollNewVersion("k6");
> EncryptedKeyVersion ekv2 = kpce.generateEncryptedKey("k6");
> Assert.assertNotEquals(ekv1.getEncryptionKeyVersionName(),
> ekv2.getEncryptionKeyVersionName());
> {code}
> with error message
> {quote}Values should be different. Actual: k6@0{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
