[
https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900373#action_12900373
]
Tsz Wo (Nicholas), SZE commented on HADOOP-6884:
------------------------------------------------
> You've benchmarked a case that isn't in the existing patch (3 variables) and
> certainly isn't typical. ...
Which patch are you talking about? I found at least two three-variable cases
in Erik's latest patch.
{code}
- LOG.debug("Exception while invoking " + method.getName()
- + " of " + implementation.getClass() + ". Retrying."
- + StringUtils.stringifyException(e));
+ if(LOG.isDebugEnabled()) {
+ LOG.debug("Exception while invoking " + method.getName()
+ + " of " + implementation.getClass() + ". Retrying."
+ + StringUtils.stringifyException(e));
+ }
{code}
{code}
- LOG.debug("for protocol authorization compare (" + clientPrincipal + "): "
- + shortName + " with " + user.getShortUserName());
+ if(LOG.isDebugEnabled()) {
+ LOG.debug("for protocol authorization compare (" + clientPrincipal +
+ "): " + shortName + " with " + user.getShortUserName());
{code}
> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
> Key: HADOOP-6884
> URL: https://issues.apache.org/jira/browse/HADOOP-6884
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Erik Steffl
> Assignee: Erik Steffl
> Fix For: 0.22.0
>
> Attachments: FunAgain.java, FunAgain.java, HADOOP-6884-0.22-1.patch,
> HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is
> true, in some cases it's expensive to construct the string that is being
> printed to log. It's much easier to always use LOG.isDebugEnabled() because
> it's easier to check (rather than in each case reason whether it's necessary
> or not).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
