[
https://issues.apache.org/jira/browse/HADOOP-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129247#comment-15129247
]
Chris Nauroth commented on HADOOP-12758:
----------------------------------------
Hi [~lmccay].
This looks good overall. It looks like some logic was lifted from
{{AltKerberosAuthenticationHandler}}. Unfortunately, this also picked up some
pre-existing Checkstyle violations that were in that class. Could you review
the Checkstyle report and address it here in the CSRF filter? (No need to
clean up {{AltKerberosAuthenticationHandler}} in the scope of this JIRA though.)
Also, the JavaDocs for {{isBrowser}} don't make sense here.
> Extend CSRF Filter with UserAgent Checks
> ----------------------------------------
>
> Key: HADOOP-12758
> URL: https://issues.apache.org/jira/browse/HADOOP-12758
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Reporter: Larry McCay
> Assignee: Larry McCay
> Fix For: 2.8.0
>
> Attachments: HADOOP-12758-001.patch
>
>
> To protect against CSRF attacks, HADOOP-12691 introduces a CSRF filter that
> will require a specific HTTP header to be sent with every REST API call. This
> will affect all API consumers from web apps to CLIs and curl.
> Since CSRF is primarily a browser based attack we can try and minimize the
> impact on non-browser clients.
> This enhancement will provide additional configuration for identifying
> non-browser useragents and skipping the enforcement of the header requirement
> for anything identified as a non-browser. This will largely limit the impact
> to browser based PUT and POST calls when configured appropriately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
