[
https://issues.apache.org/jira/browse/HADOOP-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134849#comment-15134849
]
Chris Nauroth commented on HADOOP-12758:
----------------------------------------
Hi [~lmccay]. This looks good. Just a few comments:
# There is existing precedent for use of comma as the delimiter in multi-valued
configuration properties. Using comma also would let this code use convenience
methods like {{Configuration#getTrimmedStrings}}. Is there a reason that
semicolon works better here?
# Let's store {{browserUserAgents}} as a {{Pattern[]}} at initialization time.
That way, we won't need to recompile on every HTTP request.
> Extend CSRF Filter with UserAgent Checks
> ----------------------------------------
>
> Key: HADOOP-12758
> URL: https://issues.apache.org/jira/browse/HADOOP-12758
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Reporter: Larry McCay
> Assignee: Larry McCay
> Attachments: HADOOP-12758-001.patch, HADOOP-12758-002.patch,
> HADOOP-12758-003.patch
>
>
> To protect against CSRF attacks, HADOOP-12691 introduces a CSRF filter that
> will require a specific HTTP header to be sent with every REST API call. This
> will affect all API consumers from web apps to CLIs and curl.
> Since CSRF is primarily a browser based attack we can try and minimize the
> impact on non-browser clients.
> This enhancement will provide additional configuration for identifying
> non-browser useragents and skipping the enforcement of the header requirement
> for anything identified as a non-browser. This will largely limit the impact
> to browser based PUT and POST calls when configured appropriately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
