[jira] [Commented] (HADOOP-12746) ReconfigurableBase should update the cached configuration

[Xiaobing Zhou (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137705#comment-15137705
 ] 

Xiaobing Zhou commented on HADOOP-12746:
----------------------------------------

Thanks [~arpitagarwal] for the patch! Overall, it's good.
Could you explain why 
The behavior of ReconfigurableBase#ReconfigurationThread#run
{noformat}
133               String effectiveValue =
134                   parent.reconfigurePropertyImpl(change.prop, 
change.newVal);
135               if (change.newVal != null) {
136                 oldConf.set(change.prop, effectiveValue);
137               }
{noformat}

is inconsistent with that of ReconfigurableBase#reconfigureProperty
{noformat}
        if (newVal != null) {
          getConf().set(property, effectiveValue);
        } else {
          getConf().unset(property);
        }
{noformat}

BTW, many checkstyle should be fixed. Thanks!

> ReconfigurableBase should update the cached configuration
> ---------------------------------------------------------
>
>                 Key: HADOOP-12746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12746
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-12746.01.patch
>
>
> {{ReconfigurableBase}} does not always update the cached configuration after 
> a property is reconfigured.
> The older {{#reconfigureProperty}} does so however {{ReconfigurationThread}} 
> does not.
> See discussion on HDFS-7035 for more background.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)