[
https://issues.apache.org/jira/browse/HADOOP-12791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142520#comment-15142520
]
Steve Loughran commented on HADOOP-12791:
-----------------------------------------
If you are going to do this,
# better to use a @rule to specify a timeout, rather than a per-test declaration
# if you have a base test class that has the rule extends Assert, and has a
{{@before setup() }} & {{@after teardown()}}
then migration is very straightforward: just add @Test to each test* method,
> Convert tests to use JUnit4
> ---------------------------
>
> Key: HADOOP-12791
> URL: https://issues.apache.org/jira/browse/HADOOP-12791
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Minor
> Labels: supportability, unittest
>
> Similar to HDFS-3711 and HDFS-3583, convert Hadoop Common tests that use
> JUnit3 to use JUnit4.
> JUnit4 is better over JUnit3 as it can specify additional properties such as
> timeout.
> Currently, there are 34 test files that potentially use JUnit3:
> ./hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMappingWithDependency.java:public
> class TestScriptBasedMappingWithDependency extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java:public
> class TestScriptBasedMapping extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java:public
> class TestGenericsUtil extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java:public
> class TestRunJar extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestFileBasedIPList.java:public
> class TestFileBasedIPList extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestCacheableIPList.java:public
> class TestCacheableIPList extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestIndexedSort.java:public
> class TestIndexedSort extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestAsyncDiskService.java:public
> class TestAsyncDiskService extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestNativeLibraryChecker.java:public
> class TestNativeLibraryChecker extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericOptionsParser.java:public
> class TestGenericOptionsParser extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java:public
> class TestMetricsServlet extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java:public
> class TestOutputRecord extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java:public
> class TestTrash extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java:public class
> TestDU extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java:public class
> TestPath extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemPermission.java:public
> class TestLocalFileSystemPermission extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestTruncatedInputBug.java:public
> class TestTruncatedInputBug extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetFileBlockLocations.java:public
> class TestGetFileBlockLocations extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/permission/TestFsPermission.java:public
> class TestFsPermission extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestAvroFSInput.java:public
> class TestAvroFSInput extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFs.java:public
> class TestFilterFs extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobExpander.java:public
> class TestGlobExpander extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:public
> abstract class FileSystemContractBaseTest extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/ipc/TestFairCallQueue.java:public
> class TestFairCallQueue extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/security/token/TestToken.java:public
> class TestToken extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/security/TestWhitelistBasedResolver.java:public
> class TestWhitelistBasedResolver extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/security/TestAuthenticationFilter.java:public
> class TestAuthenticationFilter extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/log/TestLog4Json.java:public
> class TestLog4Json extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/log/TestLogLevel.java:public
> class TestLogLevel extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationSubclass.java:public
> class TestConfigurationSubclass extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java:public
> class TestDeprecatedKeys extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java:public
> class TestConfServlet extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/conf/TestGetInstances.java:public
> class TestGetInstances extends TestCase {
> ./hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java:public
> class TestConfiguration extends TestCase {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
