[ 
https://issues.apache.org/jira/browse/HADOOP-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144608#comment-15144608
 ] 

Larry McCay commented on HADOOP-12548:
--------------------------------------

[~cnauroth] - thanks for catching that logic issue. I am going to change the 
catch and logging to a catch and throw a new IOException with the previous 
logging message for additional context and remove the later test for null 
credentials and exception.

The test method names... I didn't add that test class and continued the 
upperclass style as odd as it felt. I can certainly change all the methods to 
proper case if that makes. If I don't hear otherwise in a few hours, I will 
just go ahead and do that. Test method names shouldn't be referenced anywhere 
directly but I will try and ensure that they aren't.

> read s3 creds from a Credential Provider
> ----------------------------------------
>
>                 Key: HADOOP-12548
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12548
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs/s3
>            Reporter: Allen Wittenauer
>            Assignee: Larry McCay
>         Attachments: CredentialProviderAPIforS3FS-002.pdf, 
> HADOOP-12548-01.patch, HADOOP-12548-02.patch, HADOOP-12548-03.patch, 
> HADOOP-12548-04.patch, HADOOP-12548-05.patch, HADOOP-12548-06.patch
>
>
> It would be good if we could read s3 creds from a source other than via a 
> java property/Hadoop configuration option



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to