[
https://issues.apache.org/jira/browse/HADOOP-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145681#comment-15145681
]
Chris Nauroth commented on HADOOP-12548:
----------------------------------------
+1 for patch v07. I did a successful full test run using my S3 credentials. I
did find a test failure that is unrelated to this patch. I filed HADOOP-12801
to track that.
Thanks very much, Larry! I'm going to hold off committing for a while in case
any of the other reviewers want to take another look.
I didn't realize the existing tests in this suite had the wrong capitalization.
Thanks for the diligence on code cleanup too.
bq. Things catching {{FileNotFoundException}} won't catch the IOE you
re-throw...
I think this is OK. The user-facing API where these exceptions would propagate
is {{FileSystem#initialize}}. The documented contract of that method is to
throw {{IOException}}, with no extra significance attached to
{{FileNotFoundException}} or any other subclass.
> read s3 creds from a Credential Provider
> ----------------------------------------
>
> Key: HADOOP-12548
> URL: https://issues.apache.org/jira/browse/HADOOP-12548
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/s3
> Reporter: Allen Wittenauer
> Assignee: Larry McCay
> Attachments: CredentialProviderAPIforS3FS-002.pdf,
> HADOOP-12548-01.patch, HADOOP-12548-02.patch, HADOOP-12548-03.patch,
> HADOOP-12548-04.patch, HADOOP-12548-05.patch, HADOOP-12548-06.patch,
> HADOOP-12548-07.patch
>
>
> It would be good if we could read s3 creds from a source other than via a
> java property/Hadoop configuration option
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
