[
https://issues.apache.org/jira/browse/HADOOP-12794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145887#comment-15145887
]
Junping Du commented on HADOOP-12794:
-------------------------------------
Thanks [~rmutyala] for contributing the patch.
The patch looks good in overall. However, it could be better to add unit test
for some of added compress levels in {{TestZlibCompressorDecompressor}} (a good
example could be: testCompressorDecompressorWithExeedBufferLimit()).
Also, for name of some CompressionLevel, like 6, shall we follow existing
naming practice to name it as BEST_BALANCE for balance between compression
ratio and speed?
Last but not the least, it seems like some checkstyle issues (missing dot for
first line) that should be easily fixed.
> Support additional compression levels for GzipCodec
> ---------------------------------------------------
>
> Key: HADOOP-12794
> URL: https://issues.apache.org/jira/browse/HADOOP-12794
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 2.7.2
> Reporter: Ravi Mutyala
> Assignee: Ravi Mutyala
> Fix For: 2.7.3
>
> Attachments: HADOOP-12794.0001.patch
>
>
> gzip supports compression levels 1-9. Compression level 4 seems to give best
> compression per CPU time in some of our tests. Right now ZlibCompressor that
> is used by GzipCodec only supports levels 1,9 and six (default).
> Adding all the compression levels that are supported by native ZlibCompressor
> can provide more options to tweak compression levels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
