[ 
https://issues.apache.org/jira/browse/HADOOP-10865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150010#comment-15150010
 ] 

Masatake Iwasaki commented on HADOOP-10865:
-------------------------------------------

Hmm.. {{TestDFSClientRetries#testRetryOnChecksumFailure}} expects that the 
description of ChecksumException contains "Checksum error". (Jenkins did not 
run the test because it is under hadoop-hdfs.)

{noformat}
java.lang.AssertionError: Expected to find 'Checksum error' but got unexpected 
exception:org.apache.hadoop.fs.ChecksumException: Checksum CRC32C not matched 
for file /corrupted at position 0: expected=3047312A but computed=B5E7A6EF, 
algorithm=PureJavaCrc32C
        ...
        at 
org.apache.hadoop.hdfs.TestDFSClientRetries.testRetryOnChecksumFailure(TestDFSClientRetries.java:930)
{noformat}

The assertion or {{DataChecksum#throwChecksumException}} should be fixed to 
match these.

{code}
      try {
          dis.read(arr, 0, (int)FILE_LENGTH);
          fail("Expected ChecksumException not thrown");
        } catch (Exception ex) {
          GenericTestUtils.assertExceptionContains(
              "Checksum error", ex);
        }
      }
{code}


> Add a Crc32 chunked verification benchmark for both directly and non-directly 
> buffer cases
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-10865.002.patch, c10865_20140717.patch, 
> c10865_20160216.patch, c10865_20160216b.patch
>
>
> Currently, it is not easy to compare Crc32 chunked verification 
> implementations.  Let's add a benchmark.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to