[ 
https://issues.apache.org/jira/browse/HADOOP-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151330#comment-15151330
 ] 

Chris Nauroth commented on HADOOP-11031:
----------------------------------------

Hi [~lmccay].  Patch v002 is looking better to me.  It looks like this has 
addressed points 1, 2 and 5 from my prior comment.  That leaves 3, 4 and 6 as 
open issues to be addressed (or let me know if you disagree with any of them).  
To recap, here is a copy-paste:

3. Where the {{Configuration#getPassword}} method is mentioned, we can make it 
a hyperlink to the JavaDocs.

4. The document mentions that it will cover "how to create custom providers" 
and "an example of its use will be included", but I didn't find that. I assume 
it just wasn't done yet, so please consider adding it in the next patch 
revision. I also think it's acceptable to drop the mention of it and defer that 
kind of deep customization to a later patch. I think the initial goal here was 
to make basic usage easier to understand.

6. I think we should discuss how to control the keystore password for the jceks 
provider ({{HADOOP_CREDSTORE_PASSWORD}} environment variable or 
{{hadoop.security.credstore.java-keystore-provider.password-file}} 
configuration property if not in environment).


> Design Document for Credential Provider API
> -------------------------------------------
>
>                 Key: HADOOP-11031
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11031
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: site
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>         Attachments: CredentialProviderAPI.md, HADOOP-11031-001.patch, 
> HADOOP-11031-002.patch
>
>
> Provide detailed overview of the design, intent and use of the credential 
> management API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to