[
https://issues.apache.org/jira/browse/HADOOP-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kai Zheng updated HADOOP-12818:
-------------------------------
Attachment: HADOOP-12818-v1.patch
Uploaded a patch:
* Deprecate the {{RPC#waitForProxy}} and {{RPC#waitForProtocolProxy}} APIs;
* Cleaned up the codes in the real implementation of
{{RPC#waitForProtocolProxy}} by simply calling {{RPC#getProtocolProxy}}.
* Also cleaned up some minors by the chance.
> Deprecate RPC#waitForProxy and cleanup
> --------------------------------------
>
> Key: HADOOP-12818
> URL: https://issues.apache.org/jira/browse/HADOOP-12818
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-12818-v1.patch
>
>
> Copied
> [comment|https://issues.apache.org/jira/browse/HADOOP-12579?focusedCommentId=15105019&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15105019]
> from HADOOP-12579:
> {quote}
> RPC#waitForProxy method family may also be deprecated, considering:
> We probably never need to wait, giving current available engines. The
> proxy can be created and returned on demand shortly. No network connection is
> incurred.
> In the real implementation codes of waitForProtocolProxy, it uses a while
> loop to try and try until a passed timeout value is consumed. I guess the
> logic and codes were from early days of the project? Because no connection is
> made during the proxy creating and initializing. The real network connection
> is only made when the invoker is invoked and a RPC call is called.
> Most places call RPC#getProxy already.
> Not sure to remove these, considering codes out of Hadoop might call
> them. But deprecate them should be fine and change the implementation
> removing the while loop and timeout stuffs.
> {quote}
> As [[email protected]] commented, considering there may be downstream
> applications that call the APIs, better just to deprecate them even they're
> obsolete now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
